-
-
Notifications
You must be signed in to change notification settings - Fork 16
Fix analogWrite() #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@KurtE can you try giving it a spin? |
Will try it out. Running the west update now. For some reason I assumed that using the bootstrap.sh would update everything... |
I verified that at least most of the PWM pins work, a few I did not test as they were hooked up to my lcd display..., but tried, I also tried the DAC and my simple sketch worked:
|
Side note: I wish that some of these apis did not have two forms of their API. However for analogRead where the A0-A7 is done by one API with one data type and A8-A11 are done by another API with But that is probably just me. Glad more things are working! |
The big problem about A8-A11 on the Giga is that the pins can't be used as digital, so either we pollute the whole core for a single use case (which feels very wrong) or we implement something as we did (which indeed creates problems when wrapping the function call, but keeps the core clean) |
Implement DAC and fix the dtoverlay for Giga
Fixes #38 and #19